Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions thrown on reflection based calls #28361

Merged
merged 4 commits into from Mar 12, 2024

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented Mar 5, 2024

Fixes #https://github.com/gradle/gradle-private/issues/4114

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@jbartok jbartok added this to the 8.8 RC1 milestone Mar 5, 2024
@jbartok jbartok requested a review from h0tk3y March 5, 2024 10:33
@jbartok jbartok self-assigned this Mar 5, 2024
@jbartok jbartok requested a review from a team as a code owner March 5, 2024 10:33
Copy link
Member

@h0tk3y h0tk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An integration test would be in order, as mentioned in the discussion. We have tests with custom plugins in DeclarativeDslProjectBuildFileIntegrationSpec which might be an example (or something you might want to improve as well if you have better test fixtures for plugins).

@jbartok jbartok force-pushed the jb/declarative-dsl/improve-exception-handling branch from be61612 to c1f4f06 Compare March 11, 2024 09:06
@jbartok jbartok requested a review from a team as a code owner March 11, 2024 09:06
@jbartok
Copy link
Member Author

jbartok commented Mar 12, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@jbartok
Copy link
Member Author

jbartok commented Mar 12, 2024

@bot-gradle test and merge

@gradle gradle deleted a comment from jbartok Mar 12, 2024
@bot-gradle bot-gradle added this pull request to the merge queue Mar 12, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has started. Click here to see all failures if any.

Merged via the queue into master with commit b0c8c04 Mar 12, 2024
51 of 53 checks passed
@bot-gradle bot-gradle deleted the jb/declarative-dsl/improve-exception-handling branch March 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants