Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins { } in settings.gradle.something #28345

Merged
merged 4 commits into from Mar 6, 2024

Conversation

h0tk3y
Copy link
Member

@h0tk3y h0tk3y commented Mar 4, 2024

  • Evaluate pluginManagement { ... } and plugins { ... } before everything else in settings.gradle.something.
  • Introduce some utilities for AnalysisStatementFilter, allowing use-sites to be more declarative.

@h0tk3y h0tk3y self-assigned this Mar 4, 2024
@h0tk3y h0tk3y requested a review from a team as a code owner March 4, 2024 15:13
@h0tk3y h0tk3y requested a review from eskatos March 4, 2024 15:18
@h0tk3y
Copy link
Member Author

h0tk3y commented Mar 4, 2024

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Nice simplifications along the way

@h0tk3y h0tk3y added this pull request to the merge queue Mar 5, 2024
@bot-gradle bot-gradle added this to the 8.8 RC1 milestone Mar 5, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has started. Click here to see all failures if any.

@bot-gradle
Copy link
Collaborator

The merge queue build has failed. Click here to see all failures.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@h0tk3y h0tk3y added this pull request to the merge queue Mar 6, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has started. Click here to see all failures if any.

Merged via the queue into master with commit 59bc291 Mar 6, 2024
54 checks passed
@h0tk3y h0tk3y deleted the sigushkin/declarative-dsl/settings-plugins branch March 6, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants