Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup and test DependenciesExtensions and FunctionExtractor using DependencyCollector #28298

Merged
merged 17 commits into from Mar 1, 2024

Conversation

tresat
Copy link
Member

@tresat tresat commented Feb 29, 2024

This will handle any extension type annotated with @Restricted that includes getters that return DependencyCollector.

For instance:

@Restricted
public interface DependenciesExtension extends PlatformDependencyModifiers, TestFixturesDependencyModifiers, GradleDependencies {
    DependencyCollector getApi();
    DependencyCollector getImplementation();
}

should now be usable like:

someType
    dependenciesExtension {
        api("com.google.guava:guava:30.1.1-jre")
        implementation("com.apache.commons:commons-lang3:3.12.0")
    }
}

without any additional configuration.

@tresat tresat changed the title Setup FunctionExtractor for DependencyCollector Setup and test DependenciesExtensions and FunctionExtractor using DependencyCollector Feb 29, 2024
@tresat tresat added this to the 8.8 RC1 milestone Feb 29, 2024
@gradle gradle deleted a comment from tresat Feb 29, 2024
@tresat tresat marked this pull request as ready for review February 29, 2024 21:12
@tresat tresat requested a review from a team as a code owner February 29, 2024 21:12
@tresat
Copy link
Member Author

tresat commented Mar 1, 2024

@bot-gradle test this

@gradle gradle deleted a comment from tresat Mar 1, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@tresat tresat requested a review from a team as a code owner March 1, 2024 15:42
Copy link

gitstream-cm bot commented Mar 1, 2024

🥷 Code experts: jbartok, h0tk3y

jbartok, h0tk3y have most 👩‍💻 activity in the files.
ldaley, h0tk3y have most 🧠 knowledge in the files.

See details

platforms/core-configuration/declarative-dsl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/project/dependencyConfigurationSchema.kt

Activity based on git-commit:

jbartok h0tk3y
MAR
FEB 113 additions & 13 deletions 20 additions & 12 deletions
JAN
DEC
NOV
OCT

Knowledge based on git-blame:
h0tk3y: 87%

subprojects/distributions-integ-tests/src/integTest/groovy/org/gradle/AllDistributionIntegrationSpec.groovy

Activity based on git-commit:

jbartok h0tk3y
MAR
FEB
JAN 1 additions & 1 deletions
DEC
NOV
OCT

Knowledge based on git-blame:
ldaley: 66%

subprojects/distributions-integ-tests/src/integTest/groovy/org/gradle/DistributionIntegritySpec.groovy

Activity based on git-commit:

jbartok h0tk3y
MAR
FEB
JAN 1 additions & 1 deletions
DEC 2 additions & 2 deletions
NOV
OCT

Knowledge based on git-blame:
ldaley: 13%

subprojects/distributions-integ-tests/src/integTest/groovy/org/gradle/DocsDistributionIntegrationSpec.groovy

Activity based on git-commit:

jbartok h0tk3y
MAR
FEB
JAN 2 additions & 2 deletions
DEC
NOV
OCT

Knowledge based on git-blame:

subprojects/distributions-integ-tests/src/integTest/groovy/org/gradle/SrcDistributionIntegrationSpec.groovy

Activity based on git-commit:

jbartok h0tk3y
MAR
FEB
JAN 3 additions & 3 deletions
DEC 1 additions & 1 deletions
NOV
OCT

Knowledge based on git-blame:
ldaley: 53%

To learn more about /:\ gitStream - Visit our Docs

@tresat
Copy link
Member Author

tresat commented Mar 1, 2024

@bot-gradle test and merge

@gradle gradle deleted a comment from tresat Mar 1, 2024
@bot-gradle bot-gradle added this pull request to the merge queue Mar 1, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has started. Click here to see all failures if any.

Merged via the queue into master with commit cebf576 Mar 1, 2024
27 checks passed
@bot-gradle bot-gradle deleted the tt/88/function-collector-for-dependency-collector branch March 1, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants