Add swiftLibrary and swiftApplication software types
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementations don't do anything yet.
tresat
approved these changes
May 14, 2024
| import org.gradle.declarative.dsl.model.annotations.Restricted; | ||
|
|
||
| @Restricted | ||
| public interface HasSwiftTarget { |
There was a problem hiding this comment.
🤔 I don't think this name makes sense. The target is implicit and not visible in the DSL, the name makes it sound like an implementing type would have a getTarget() method defined (which would then hold the version property).
Could we call it SwiftProject or CompilesToSwift or something instead?
There was a problem hiding this comment.
The target is absolutely both explicit and visible in the DSL, as the swiftVersion property.
There's a bunch of interfaces with this naming scheme, we can do a pass over them and improve their names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.