Add coordinate system diagrams and fix NDC to framebuffer equation #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previews, as seen when this build job started (88686ad): |
kainino0x
reviewed
May 17, 2024
Co-authored-by: Kai Ninomiya <kainino@chromium.org>
Co-authored-by: Kai Ninomiya <kainino@chromium.org>
kainino0x
reviewed
May 17, 2024
Co-authored-by: Kai Ninomiya <kainino@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4492
Updates the equation for transforming NDC coordinates to framebuffer coordinates to account for the necessary Y flip. Also, because I felt like it would be nice, I added a few diagrams to visually illustrate several of the coordinate systems. I also included a non-normative note to explain that WebGPU can treat either 0 or 1 as the zNear plane, depending on the render state used.