Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add first and either to interpolate #4639

Merged
merged 7 commits into from
May 22, 2024
Merged

add first and either to interpolate #4639

merged 7 commits into from
May 22, 2024

Conversation

greggman
Copy link
Contributor

No description provided.

@greggman greggman requested a review from dneto0 May 14, 2024 02:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Previews, as seen when this build job started (3419f0d):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@greggman
Copy link
Contributor Author

#4489

alan-baker
alan-baker requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly editorial suggestions.

wgsl/index.bs Outdated Show resolved Hide resolved
wgsl/index.bs Outdated Show resolved Hide resolved
wgsl/index.bs Outdated Show resolved Hide resolved
wgsl/index.bs Outdated Show resolved Hide resolved
wgsl/index.bs Outdated Show resolved Hide resolved
wgsl/index.bs Outdated Show resolved Hide resolved
@greggman greggman mentioned this pull request May 14, 2024
Merged
greggman and others added 6 commits May 14, 2024 08:12
@greggman @alan-baker
Update wgsl/index.bs
3419f0d 
Co-authored-by: alan-baker <alanbaker@google.com>
@greggman @alan-baker
Update wgsl/index.bs
8966a11 
Co-authored-by: alan-baker <alanbaker@google.com>
@greggman @alan-baker
Update wgsl/index.bs
1a02a67 
Co-authored-by: alan-baker <alanbaker@google.com>
@greggman @alan-baker
Update wgsl/index.bs
a943568 
Co-authored-by: alan-baker <alanbaker@google.com>
@greggman @alan-baker
Update wgsl/index.bs
365dd26 
Co-authored-by: alan-baker <alanbaker@google.com>
@greggman @alan-baker
Update wgsl/index.bs
297e335 
Co-authored-by: alan-baker <alanbaker@google.com>
@greggman
Copy link
Contributor Author

This is ready?

@kainino0x kainino0x requested a review from alan-baker May 20, 2024 21:03
@alan-baker
Copy link
Contributor

Content-wise it LGTM, but I wasn't sure if this was to be landed with compat changes or separately.

@kainino0x kainino0x added the wgsl WebGPU Shading Language Issues label May 21, 2024
@greggman greggman merged commit 266238c into gpuweb:main May 22, 2024
4 checks passed
@greggman greggman deleted the flat-either-first branch May 22, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker approved these changes

@dneto0 dneto0 Awaiting requested review from dneto0

Assignees
No one assigned
Labels
wgsl WebGPU Shading Language Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greggman @alan-baker @kainino0x