Deduped most image/buffer copy validation #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previews, as seen when this build job started (0a2332b): |
|
Oh! Also forgot to mention that I noticed that I missed updating |
kainino0x
reviewed
May 17, 2024
| |dstTexture|.{{GPUTexture/format}}. | ||
| - That aspect must be a valid image copy destination according to [[#depth-formats]]. | ||
| - Set |aspectSpecificFormat| to the [=aspect-specific format=] according to [[#depth-formats]]. | ||
| - [=validating texture copy range=](|destination|, |copySize|) return `true`. |
There was a problem hiding this comment.
This step seems to be missing now?
There was a problem hiding this comment.
Thanks for catching that. I tried so hard to make sure everything got pulled over, but with as much rearranging as it required I guess I'm not too surprised I missed a step.
kainino0x
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1192
Takes a lot of the Texture<->Buffer image copy validation logic and dedups it into a single algorithm. Original issue only requested the "single-aspect" validation bits be deduped, but in the end there was a lot more shared logic between three functions that did that check that could be unified.