-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making valid, invalid, and expired regular properties #4625
Conversation
Previews, as seen when this build job started (5658e07): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!
Thanks for the suggestions! Applied those, normalized all the invalid->lost instances I could find, refactored the Think it's ready for a proper review now. |
Sorry, just realized I lost track of this one. I've put it back in my review inbox. |
Co-authored-by: Kai Ninomiya <kainino@chromium.org>
WIP. Removing the rather fuzzy definitions that we have for
valid
andinvalid
and replacing them with actual properties and algorithms that reference them.Additionally, defines an explicit
expired
property for adapters rather than using it as an alias forvalid
since the newvalid
property exists on theGPUObjectBase
, which adapters don't use.TODO: A couple of algorithms are referencing the new
valid/invalid
algorithims from thecontent
timeline, which shouldn't be allowed. Also, the definition forinvalid
is stupid. Finally, there's a couple of references tolost
for devices which are aliases forvalid
. Feels like that should be normalized.