Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate all command buffers passed to submit, whether the submit is valid or not. #4608

Merged
merged 1 commit into from
May 15, 2024

Conversation

toji
Copy link
Member

@toji toji commented Apr 26, 2024

Fixes #4599, assuming that we agree that this should be the behavior.

Copy link
Contributor

Previews, as seen when this build job started (24f19aa):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x kainino0x added this to the Milestone 1 milestone Apr 26, 2024
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM editorially.

@mwyrzykowski mwyrzykowski self-requested a review May 8, 2024 17:57
@toji
Copy link
Member Author

toji commented May 15, 2024

This behavior was agreed on during today's call.

@toji toji merged commit 91efc67 into main May 15, 2024
4 checks passed
@toji toji deleted the submit_invalidates branch May 15, 2024 19:19
@kainino0x kainino0x added needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet api resolved Resolved - waiting for a change to the API specification labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api resolved Resolved - waiting for a change to the API specification needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should command buffers be invalidated by an invalid submit?
3 participants