-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended range #4500
base: main
Are you sure you want to change the base?
Add extended range #4500
Conversation
Previews, as seen when this build job started (7a3b59a): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The worked examples are great. A few small comments (and holding "editor" approval until others have reviewed)
FYI I added this to the PR summary to link the issue. Is it correct that landing this would fix/close that issue? |
From kainino0x review Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
Yes, thanks! |
Yes! |
Friendly review bump @kdashg @mwyrzykowski |
Sorry! It looks good, I forgot to click approve 👍 |
@ccameron-chromium let me know that CSS is hotly debating gamut mapping right now, and we may need to be less prescriptive in this spec lest we contradict what CSS eventually does. I've converted this to draft so it can't be landed accidentally. |
We had originally called the modes The core behavior that we want to capture is that
I could imagine changing the names to |
I probably should have put this on the agenda for today's meeting, but didn't think about it. We're probably not having another WG meeting for 3 weeks but that should be OK. I've put this on the editors' agenda for this coming Monday so we can talk about naming and then try to get reapproval. |
proposal became less strict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names and language LGTM, just small comments to label non-normative language as non-normative.
@kdashg @mwyrzykowski could you re-review with the loosened wording and new naming? |
GPU Web WG 2024-05-15
|
@kdashg review bump! |
Add color metadata to canvas configuration, with the ability to specify an extended range.
Move the clarification of the handling out out-of-range values to the subsection on specific values, and add an example of extended range values.
Fixes #4239