Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify typography of abstract int 0 and abstract float 0 #4485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify typography of abstract int 0 and abstract float 0 #4485

wants to merge 1 commit into from

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Feb 7, 2024

@dneto0 dneto0 added wgsl WebGPU Shading Language Issues copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) labels Feb 7, 2024
@dneto0 dneto0 mentioned this pull request Feb 7, 2024
Merged
mehmetoguzderin
mehmetoguzderin reviewed Feb 7, 2024
View reviewed changes
wgsl/index.bs
Comment on lines +12236 to +12237
* The zero value of an [=AbstractInt=] is `0`
* The zero value of an [=AbstractFloat=] is `0.0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the omission of trailing dots intentional? Thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
I don't want readers to mistake this for part of the syntax of the token.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Previews, as seen when this build job started (5049796):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

alan-baker
alan-baker reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just address this as part of #4451. This change makes the bullets more inconsistent than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmetoguzderin mehmetoguzderin mehmetoguzderin left review comments

@alan-baker alan-baker alan-baker left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) wgsl WebGPU Shading Language Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dneto0 @mehmetoguzderin @alan-baker