Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider deduplicating "must be a single aspect" validation #1192

Closed
kainino0x opened this issue Oct 29, 2020 · 3 comments · Fixed by #4629
Closed

Consider deduplicating "must be a single aspect" validation #1192

kainino0x opened this issue Oct 29, 2020 · 3 comments · Fixed by #4629
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)
Projects
Main
Milestone
Milestone 0

Comments

@kainino0x
Copy link
Contributor

As a followup to #873, consider deduplicating the "must be a single aspect" validation into a common place for B2T/T2B/writeTexture.

Maybe this belongs in validating linear texture data, or in a new algorithm which calls that. e.g. linear texture copy is valid

Originally posted by @kainino0x in #873 (comment)
@kainino0x
Copy link
Contributor Author

cc @austinEng

@kainino0x
Copy link
Contributor Author

I believe such a new algorithm could also deduplicate the validating GPUBufferCopyView call, the Valid Texture Copy Range call, and the texture.[[sampleCount]] == 1 check.

@kainino0x
Copy link
Contributor Author

cc @toji too

@kvark kvark added this to Needs Specification in Main Nov 9, 2020
@Kangz Kangz added this to the V1.0 milestone Sep 2, 2021
@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label Nov 24, 2021
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this issue Sep 6, 2022
@dj2
Add literal parsing tests (gpuweb#1193)
972308d 
This PR adds tests for literal parsing of bool, int and float values.

Issue: gpuweb#1192
@kainino0x kainino0x modified the milestones: V1.0, Polish post-V1 Mar 2, 2023
@kainino0x kainino0x modified the milestones: Polish post-V1, V1.0 Aug 15, 2023
@kainino0x kainino0x added the api WebGPU API label Apr 30, 2024
@toji toji mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)
Projects
No open projects
Main
Needs Specification
Milestone
Milestone 0
Development

Successfully merging a pull request may close this issue.

Deduped most image/buffer copy validation gpuweb/gpuweb
2 participants
@Kangz @kainino0x