really drop python<=3.7 support #1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter all code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
|
Are all the vim-comment removals necessary? Whilst I don't use Vim myself, I assume whoever added those headers (@bennuttall or @waveform80 ?) finds them useful; and removing those changes from this PR would make it a bit smaller. |
All python files since python 3.x are UTF-8 and vim already has hardcoded thar in its settings which was not the case with python 2.x. |
Siecje
reviewed
May 29, 2024
| division, | ||
| ) | ||
| str = type('') | ||
| str = str |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter all code over
pyupgrade --py38-plus.