Support setting custom active_state for InputDevice #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly supports now normally-closed switches with an internal pull-up/pull-down resistor as well together with normally-open switches. Before an exception was raised when attempting to modify the active state while specifying the `pull_up` parameter. This was rather an artificial limitation which is now lifted. Like before, by default it assumed that a button or switch is normally-open which is a common assumption and keeps the code backwards-compatible. In this case specifying the `active_state` parameter is not necessary. Closes gpiozero#921.
|
Is there any progress with this topic? I have the same problem and need a way to handle normally-closed switches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit the same limitation as described in #921. I use normally-closed switches for my experimental setup and needed to change the
active_stateparameter ofButtonto something else while using an internal pull-up or pull-down resistor to avoid soldering something and keep the experimental setup simple.As I commented in the issue, I went with following approach from the possibilities proposed by the original author of the issue @pmlk:
I left the other suggestion (which I think would be useful too), because it can be discussed separately and done in another PR:
Please refer to my other reasonings in my above mentioned comment. I am now lazy to copy them here 馃槢
Unit tests execute successfully skipping the real-pin tests.
I hope I have read everything correctly under the contributing page.