Update output_devices.py

[tinitaet]

Add a "fade_to()" function to the PWMOutputDevice class as well as a mod RGBLED. It uses the same blink thread as the blink function to not interfere with existing scripts.
This function takes a fade_time in seconds and fades the value/color from a start value (default: the given value at the moment) to an end value.

[tinitaet]

So far:
Add fade_to(self, fade_time=1, start_value=None, end_value=1, background=True) to PWMOutputDevice
Add fade_to(self, fade_time=1, start_color=None, end_color=(1,1,1), background=True) to RGBLED
Add cycle_color(self, cycle_time=10, start_color=None, clockwise=True, n=None, background=True) to RGBLED
Everything uses the _blink_thread to be consistent with working threading.
Code is operational and tested for usual parameters and foreseeable misuse.

[lurch]

I think if the RGBLED is currently off (i.e. current colour is black), and you call rgbled.cycle_color() then the LED won't appear to actually do anything? I can imagine that might confuse some people, so perhaps it's worth warning about that in the docstring? 🤷
(And I assume you meant "Add cycle_color ... to RGBLED" in your last comment?)

[tinitaet]

Good Point!
How about something in the means of "Caution: Only the hue parameter will change. This means, that the luminescence will stay the same, so white will stay white and black will stay black. For best (i.e. most colorful) results, use a pure color as a starting value."

Yes, I meant RGBLED and changed it… thanks for the reply 😅

[lurch]

I was going to ask "Will most people know what 'luminescence' even means?", but if you're linking to a wikipedia article that hopefully sufficiently explains things.
Just a minor point, but perhaps it's worth clarifying what you wrote slightly to "so full-white will stay white and black (i.e. off) will stay black" ?

[lurch]

Yes, I meant RGBLED and changed it…

Cool... slightly ironic that you mentioned "better description of pwmled.cycle_color()" in your commit-message 🤣

[tinitaet]

Yes, I meant RGBLED and changed it…

Cool... slightly ironic that you mentioned "better description of pwmled.cycle_color()" in your commit-message rofl

True… ^^ I start to get the impression that the documentation to explain, what this function does, is more trouble than the function itself.

[lurch]

Sorry, please forgive my pickiness!

[lurch]

👍

[lurch]

Although perhaps the tuple-values here should be in backticks? 🤔

[tinitaet]

Sorry, please forgive my pickiness!

No worry, I am not offended, but rather glad for the response. Otherwise some stuff might slip through and I want do do the best I can.

[NBoumakis]

Hello! It's been a while, but is this getting merged at some point? I too would like the provided functionality, hopefully without reinventing the wheel.

Thanks