Buildbot ffmpeg case #2817
Closed
Buildbot ffmpeg case #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see this was still in draft so I merged it since it seemed mostly cosmetic. Was it ready to merge or do you think I should revert? (I just had to fix the testsuite commit because it was outdated) |
|
It was ok but I wanted someone to review. You can merge gpac/wiki#3 too I guess! Thx |
|
merged in 8c1efba |
|
corresponding wiki PR gpac/wiki#3 merged too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also gpac/wiki#3