Fix: Do Not Skip Overlapping LCT Fragments #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touatily
force-pushed
the
buildbot-overlapping-frag
branch
from
17b5805
to
2c79c18
Compare
rbouqueau
reviewed
Mar 5, 2024
src/media_tools/route_dmx.c
Outdated
| @@ -762,7 +763,7 @@ static GF_Err gf_route_service_flush_object(GF_ROUTEService *s, GF_LCTObject *ob | |||
|
|
|||
| static GF_Err gf_route_service_gather_object(GF_ROUTEDmx *routedmx, GF_ROUTEService *s, u32 tsi, u32 toi, u32 start_offset, char *data, u32 size, u32 total_len, Bool close_flag, Bool in_order, GF_ROUTELCTChannel *rlct, GF_LCTObject **gather_obj) | |||
| { | |||
| Bool inserted, done; | |||
| Bool /*inserted,*/ done; | |||
There was a problem hiding this comment.
Before merging, let's not forget to remove the unused code.
rbouqueau
reviewed
Mar 5, 2024
src/media_tools/route_dmx.c
Outdated
| @@ -23,6 +23,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
| #include <math.h> | |||
There was a problem hiding this comment.
You could remove this by using MAX instead of fmax.
|
I made 2 minor comments. Otherwise LGTM. Thanks! |
|
Thanks for the commits, they address my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving LCT fragments, ensure that packets are not skipped if they overlap with received packets.
This fix addresses the issue where skipping overlapped packets led to potential data loss or processing errors.