-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildbot scte35 id3 markers #2748
Merged
Merged
Changes from 14 commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
b634dac
mpegts: add generic id3 tag encoded as KLV
rbouqueau bf6e591
metadata/id3: forward raw data as we don't do anything special with t…
rbouqueau 96cb1c1
m2ts mux: make data to be discarded as it is reallocated
rbouqueau 1df5296
remove old comment
rbouqueau 826bcd5
m2ts scte35: fwd support
rbouqueau d4005bd
mpegts: id3 is PES while SCTE35 is section
rbouqueau dbb180f
m2ts: prepare to use 'TEMI custom descriptor to filter prop' mechanis…
rbouqueau 045ed52
typo: unknow -> unknown
rbouqueau 5dc0971
dmx_m2ts: forward id3 and scte35 as props
rbouqueau aaa6d02
dmx_m2ts: partial revert of dbb180f37f5eb9320ccb47edd14dad234baababf
rbouqueau 941f07c
inspect: add scte35
rbouqueau 6316cc5
mux_isom: push id3 in emsg
rbouqueau c1ef5c1
strdup can't be called with NULL as arg
rbouqueau 12a672b
Merge branch 'master' into buildbot-scte35-id3-markers
rbouqueau b5081d0
scte35: enable ts remux
rbouqueau 4fc2755
isom mux: customize id3 emsg syntax according to https://aomedia.org/…
rbouqueau 835b7d0
dmx_m2ts: set pes framing for id3 streams
rbouqueau e78543b
EventMessage Track (23001-18): add boxes
rbouqueau ebe5a3f
mux_isom: create emsg box list before adding entry
rbouqueau fe4590a
isom_mux: add emsg attached to packets at each packet, not only at fr…
rbouqueau 9634380
add scte35_dec (must be explicitely instantiated)
rbouqueau 53a9e17
cosmetics
rbouqueau f053ca2
mux_isom: use strdup instead of malloc+strcpy
rbouqueau b63df1c
23001-18 event message track: first version with 'emeb' empty filling
rbouqueau 92a0fb0
dec_scte35: use dts instead of cts (in case the video input stream co…
rbouqueau a2d9ab7
dmx_m2ts: attach scte35 to video only
rbouqueau e194a8e
scte35 dmx: declare static prop on pid where the dyn prop will be att…
rbouqueau 9574251
evte: remove warnings
rbouqueau 6c2f05b
23001-18 in dash
rbouqueau bf0b41c
scte35_dec: take segmentation into account
rbouqueau f58b71e
scte35_dec: cosmetics
rbouqueau bd71339
23001-18: inspect evte
rbouqueau afc88a7
inspect scte35: misc fixes
rbouqueau 2deda55
dec_scte35: parse pts_delta and event duration+id
rbouqueau bd525d0
typo
rbouqueau 6bcb03c
23001-18: segment emib box
rbouqueau 94cb9f9
dec_scte35: don't dynamically allocate 'emeb' boxes
rbouqueau e2a8625
cosmetics
rbouqueau 623574e
scte35: dump standardized xml when inspecting
rbouqueau da30804
dec_scte35: manage drift in non-segmented mode
rbouqueau 0905b7b
dec_scte35: manage drift in segmented mode
rbouqueau 85cb9b2
dec_scte35: no duration events are assigned the last pck duration
rbouqueau ead8914
inspect: adjust bs pos when parsing is incomplete
rbouqueau 845b323
scte35dec: set default segmentation duration (1s)
rbouqueau a3054ab
remove duplicate prop set
rbouqueau fb56c2c
Handle ID3 tags as properties in TS stream.
a700056
Merge branch 'master' into buildbot-scte35-id3-markers
rbouqueau c47d2ad
fix build after merging master
rbouqueau 18dfbdb
Support ID3 tags of any length.
f2cf031
cosmetics
rbouqueau 058cebd
dec_scte35: add minimal test
rbouqueau 1f9a5a8
add compile flag to unittest build (e.g. debug info)
rbouqueau 8e651ee
fix gcc warning
rbouqueau 5baae20
dec_scte35: add first UT
rbouqueau a86d1b2
fix memleak in xml_string unit test
rbouqueau 48edd6b
misc cosmetics and checks on exported functions
rbouqueau d93c07c
scte35: clarify test structure
rbouqueau c6efacb
scte35: continue to clarify UT structure
rbouqueau bdb5b0c
scte35_dec: add UT
rbouqueau 496ef79
scte35_dec: add first test with segmentation
rbouqueau 1c323d2
scte35_dec: continue to add UTs
rbouqueau 4a82726
scte35_dec: adding all UTs (still a few FIXMEs)
rbouqueau 44cb9eb
scte35_dec: pass more tests
rbouqueau b03cfda
gf_isom_set_media_timescale returns GF_OK if there is nothing to do (…
rbouqueau 603686d
scte35: fixes while processing streams from other sources
rbouqueau 58b452d
scte35_dec: update payload and segment emeb as well
rbouqueau 67f026c
scte35_dec: improve logs to display parsed content and timings
rbouqueau 18b6c1f
scte35_dec: add m2ts section checks in all the pipeline
rbouqueau 539f291
evte: plug with MP4Box -dxml
rbouqueau 79a35d1
inspect: fix element close
rbouqueau 4b26628
fix clang compilation
rbouqueau 85261fe
Merge branch 'master' into buildbot-scte35-id3-markers
rbouqueau 49e95c5
inspect: add xml namespace
rbouqueau 99436b3
fix for non-Makefile builds
rbouqueau ca2389d
add dec_scte35 to vcxproj
rbouqueau 6192235
scte35_dec: minor refinements
rbouqueau 0a350d6
Merge branch 'master' into buildbot-scte35-id3-markers
rbouqueau 07af7a0
build tweaks
rbouqueau 4c6bcb3
adding dec_scte35 using xcode, thank you @aureliendavid
rbouqueau b478be2
scte35 dump: fix splice time inside time signal
rbouqueau 20626ef
update changelog
rbouqueau File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1098,7 +1098,6 @@ struct __gf_filter_pid | |
volatile u32 num_pidinst_del_pending; | ||
|
||
u32 link_flags; | ||
|
||
}; | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to write
pck->data_len
beforepck->data
so that other filters that parse this data know how many bytes to read? For instance hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We know the size of the property. That being said what would happen if several properties are pushed simultaneously? The spec says that "several messages in the same 'emsg' box (i.e. same message_data[] array) shall be separated with '0x0A'." Is it a realistic use-case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 271 size of the Nielsen ID3 tag is indeed known. However, if we want to push other ID3 tags of unknown size, then writing the
data_len
is needed to create theemsg
box correctly.I haven't seen this edge case in the tests I have run so far. It can be omitted for now, I think.