Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid allocations with (*regexp.Regexp).MatchString #604

Merged
merged 1 commit into from Oct 23, 2023
Merged

perf: avoid allocations with (*regexp.Regexp).MatchString #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/stream/stream.go
View file
Open in desktop
Expand Up @@ -196,7 +196,7 @@ func isAllowedOrigin(r *http.Request, allowedOrigins []*regexp.Regexp) bool {
}

for _, allowedOrigin := range allowedOrigins {
if allowedOrigin.Match([]byte(strings.ToLower(u.Hostname()))) {
if allowedOrigin.MatchString(strings.ToLower(u.Hostname())) {
return true
}
}
Expand Down
2 changes: 1 addition & 1 deletion auth/cors.go
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ func CorsConfig(conf *config.Configuration) cors.Config {
corsConf.AllowHeaders = conf.Server.Cors.AllowHeaders
corsConf.AllowOriginFunc = func(origin string) bool {
for _, compiledOrigin := range compiledOrigins {
if compiledOrigin.Match([]byte(strings.ToLower(origin))) {
if compiledOrigin.MatchString(strings.ToLower(origin)) {
return true
}
}
Expand Down