Adds applications icons in sidebar #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuscelio
changed the title
mateuscelio
force-pushed
the
adds-app-icons-to-navigation
branch
from
0564fc5
to
7da891f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 45 45
Lines 1609 1609
=======================================
Hits 1386 1386
Misses 138 138
Partials 85 85 ☔ View full report in Codecov by Sentry. |
jmattheis
reviewed
Oct 16, 2023
jmattheis
reviewed
Oct 22, 2023
| @@ -59,6 +66,13 @@ class Navigation extends Component< | |||
| to={'/messages/' + app.id} | |||
| key={app.id}> | |||
| <ListItem button> | |||
| <ListItemAvatar style={{minWidth: 42}}> | |||
| <Avatar | |||
| style={{width: 32, height: 32}} | |||
There was a problem hiding this comment.
I've changed the sizes a little bit so that it doesn't increase the height of the ListItem.
jmattheis
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #405