Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add last seen field to client (fixes #400) #582

Merged
merged 2 commits into from Aug 6, 2023

Conversation

eternal-flame-AD
Copy link
Member

This PR fixes #400 by adding a last seen field to the client model. The last seen field is updated on connection & every pong response.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.21% ⚠️

Comparison is base (a444182) 85.97% compared to head (a3ce298) 85.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   85.97%   85.76%   -0.21%     
==========================================
  Files          45       45              
  Lines        1590     1616      +26     
==========================================
+ Hits         1367     1386      +19     
- Misses        140      145       +5     
- Partials       83       85       +2     
Files Changed Coverage Δ
auth/authentication.go 69.14% <42.85%> (-1.79%) ⬇️
router/router.go 85.98% <57.14%> (-2.14%) ⬇️
api/stream/stream.go 100.00% <100.00%> (ø)
database/application.go 91.66% <100.00%> (+0.36%) ⬆️
database/client.go 91.30% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see another PR from you (:

api/stream/stream.go Outdated Show resolved Hide resolved
model/client.go Outdated Show resolved Hide resolved
model/client.go Outdated Show resolved Hide resolved
ui/src/client/Clients.tsx Outdated Show resolved Hide resolved
router/router_test.go Outdated Show resolved Hide resolved
@eternal-flame-AD
Copy link
Member Author

Thanks for the review, its been some time since I was active here. Yeah I should have read #400 more carefully you are correct we are discussing more about token last used instead of client alive-or-not.

auth/authentication.go Outdated Show resolved Hide resolved
auth/authentication.go Outdated Show resolved Hide resolved
router/router_test.go Outdated Show resolved Hide resolved
ui/src/client/Clients.tsx Show resolved Hide resolved
ui/src/application/Applications.tsx Outdated Show resolved Hide resolved
jmattheis
jmattheis previously approved these changes Aug 6, 2023
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've also extracted the ui code for the last used cell to a separate file.

@jmattheis jmattheis merged commit 8c0f7a9 into gotify:master Aug 6, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

last message/last ping in /clients
2 participants