Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from packr to go:embed #581

Merged
merged 2 commits into from Jul 15, 2023
Merged

Conversation

eternal-flame-AD
Copy link
Member

Go embed has been out for a while now and packr recommends moving to //go:embed as well, this PR removes packr from the dependency list and uses go:embed to embed swagger and UI files.

@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner July 14, 2023 23:05
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (5cd2d54) 85.99% compared to head (1f65c82) 86.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   85.99%   86.09%   +0.09%     
==========================================
  Files          45       45              
  Lines        1585     1582       -3     
==========================================
- Hits         1363     1362       -1     
+ Misses        139      138       -1     
+ Partials       83       82       -1     
Impacted Files Coverage Δ
docs/swagger.go 100.00% <100.00%> (+25.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only two remarks in subcomments.

ui/serve.go Outdated Show resolved Hide resolved
docs/swagger.go Outdated Show resolved Hide resolved
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmattheis jmattheis merged commit aedc3e2 into gotify:master Jul 15, 2023
3 checks passed
jmattheis added a commit to gotify/server-aur-git that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants