Add copy app token button in web gui #561
Conversation
ui/src/client/Clients.tsx
Outdated
| const copyToClipboard = async (text: string) => { | ||
| try { | ||
| await navigator.clipboard.writeText(text); | ||
| console.info("Copied to clipboard:", text); |
There was a problem hiding this comment.
For the notifications, Instead of using cosole.info and console.error I suggest you to make use of SnackReporter to make it look like the example below:
There was a problem hiding this comment.
Thanks for the tip! I'm trying to add an additional action to ClientStore to implement it!
There was a problem hiding this comment.
You can directly inject the SnackManager into the Clients component by adding it to the inject function:
export default inject('clientStore', 'snackManager')(Clients);
There was a problem hiding this comment.
Is it better to do it that way? I have already implemented it with an import.
|
Okay. I added a Copy to Clipboard button to "Applications" and "Plugins" too.
I have personally tested the button and it works in "Clients" and "Applications". I tried to install a plugin to test it there too but unfortunately I was not able to do it. This PR is still not ready to be merged due to e2e tests on "Applications" and "Plugins" failing. |
|
Hi. I finally realized the embarrassing thing that was making the test fail. All tests are passing now and the button is working as it should. |
There was a problem hiding this comment.
@Zlendy I left some comments. To summarize, I think that a better implementation would be create a component for the copy button and inject snack manager into it. This way, it wouldn't be necessary to change SnackManager and component's stores. To help, I created a PR into your fork. Let me know If you have more questions.
This pull request implements #447.