Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ClientParams strcut to handle creation and update params #560

Merged
merged 1 commit into from Apr 28, 2023

Conversation

mateuscelio
Copy link
Contributor

@mateuscelio mateuscelio commented Apr 24, 2023

#466

An intermediate struct was added to handle params used in creation and update client controllers preventing the edition of fields that are readOnly.

@mateuscelio mateuscelio requested a review from a team as a code owner April 24, 2023 21:50
@mateuscelio mateuscelio force-pushed the master branch 2 times, most recently from b905576 to a2f4c9d Compare April 25, 2023 22:30
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9d4e37a) 86.19% compared to head (a2f4c9d) 86.20%.

❗ Current head a2f4c9d differs from pull request most recent head f3d121b. Consider uploading reports for the commit f3d121b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   86.19%   86.20%           
=======================================
  Files          45       45           
  Lines        1565     1566    +1     
=======================================
+ Hits         1349     1350    +1     
  Misses        136      136           
  Partials       80       80           
Impacted Files Coverage Δ
api/client.go 72.97% <100.00%> (+0.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jmattheis
jmattheis previously approved these changes Apr 28, 2023
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmattheis jmattheis merged commit a18970e into gotify:master Apr 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants