Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ipython-profile support #266

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

woutervh
Copy link
Contributor

  • add ipython-profile support

Wouter Vanden Hove and others added 3 commits March 12, 2023 02:56
* add ipython-profile support

* add tests to fetch ipytohn_profiler from config

---------

Co-authored-by: Wouter Vanden Hove <wvandenhove@ekglobal.co>
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Patch coverage: 89.28% and project coverage change: -0.62 ⚠️

Comparison is base (3326c07) 81.64% compared to head (9726ed8) 81.02%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   81.64%   81.02%   -0.62%     
==========================================
  Files           7        7              
  Lines         512      564      +52     
==========================================
+ Hits          418      457      +39     
- Misses         94      107      +13     
Impacted Files Coverage Δ
ipdb/__main__.py 67.25% <70.00%> (+0.11%) ⬆️
tests/test_config.py 93.01% <100.00%> (-2.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tests/test_config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
@gotcha
Copy link
Owner

gotcha commented Mar 22, 2023

Thanks for this PR.
I am sure it will be appreciated.
See my first comments. I'll dig deeper.

* add ipython-profile support

* add tests to fetch ipytohn_profiler from config

* cleanup profile-tests

---------

Co-authored-by: Wouter Vanden Hove <wvandenhove@ekglobal.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants