Drop Python 2.7 support #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to keep 2.7 support unless it avoids support for new features... |
Upstream IPython dropped it in version 6.0.0, in April 2017. I think it's fine to drop it here now. Would also be good to use this opportunity to mark the release as 1.0.0.
adamchainz
force-pushed
the
drop_python_2.7
branch
from
9fffde9
to
d608997
Compare
|
Why? It's dead for nearly 2 years now. For those on Python 2, pip will install the old version, thanks to |
|
As said above, if it does not hinder new features, I see no reason to stop support. Further, I know a lot of people still using Py 2. |
|
Okay well up to you. You can keep this PR open for when the time comes if you like. |
|
Good point |
|
2.7 IPython vulernability fixes won't be installable through pip for #248, as they're installable from source only. |
ssbarnea
approved these changes
Aug 8, 2022
|
@gotcha merge it please! Let's avoid disturbing the dead, or better avoid being hunted by zombies. |
ulgens
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream IPython dropped it in version 6.0.0, in April 2017. I think it's fine to drop it here now.
Would also be good to use this opportunity to mark the release as 1.0.0.