Add hide donation message option in add subcommand #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list. |
|
@atamakahere-git Any updates on this? |
theRookieCoder
requested changes
May 21, 2024
| @@ -51,6 +51,10 @@ pub enum SubCommands { | |||
| /// The mod loader will not be checked for this mod | |||
| #[clap(long, short = 'M', alias = "dont-check-mod-loader")] | |||
| ignore_mod_loader: bool, | |||
|
|
|||
| /// Ignore the donation message | |||
| #[clap(long, short = 'H', alias = "hide-donation-message")] | |||
There was a problem hiding this comment.
The alias here is unnecessary, clap will automatically convert Rust snake_case variables and PascalCase subcommands to the standard kebab-case used in CLIs.
- #[clap(long, short = 'H', alias = "hide-donation-message")]
+ #[clap(long, short = 'H')]There was a problem hiding this comment.
Also I think Hide the donation message is good for the description too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for #369