-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI tweaks resolving #250 #332
base: main
Are you sure you want to change the base?
Conversation
Hmm I don't think a separate info subcommand is needed, I was thinking something like that would be added to the list command instead. |
In the original proposal I mentioned
I also noticed, that I often switch profiles and need to know the most crucial info about my active one without the whole long list of mods:
If I were to implement the original proposal of including profile info in the
I noticed that I started using |
I don't know how to add an alias I think I finished my job in this PR. |
I've noticed, that the download log after I noticed it's a problem with padded rust macros e.g. |
I think this can be merged for now as-is after you review @theRookieCoder. If you have some idea how to deal properly with emoji character widths in padded I am a bit hesitant to add |
@theRookieCoder, will you merge? |
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list. |
@blarfoon it would be good if you changed cla-bot so it doesn't require sending the email but simply clicking a button/commenting (or use cla-assistant instead). |
Yeah eventually you'll just need to click a link and sign the document, this email thing is temporary. Sorry for the inconvenience |
Partially implemented #250
ferium info
should show information about the current profile and modpackferium profile info
added instead to be more scopedferium modpack info
info should be added in a similar mannerferium profile list
- tweaked the active profile indicator to be bold green(active)
suffix next to profile name.ferium add
fails,link to documentation about overrides (https://github.com/gorilla-devs/ferium#check-overrides)hint about--dont-check-*
flags as part of the error message.instead useferium profile
should print the current profile, then Runferium profile -h
for more info about this command (likewise for ferium modpack too)ferium profile info
to align with current usage patternsferium list
should print a header with information about the profile about to be listed (i.e. profile name, loader, and mc version) as well--markdown
flag in theferium list -vm
variantferium profile switch
should print more info about the profiles, not just the nameslikewise forno need for thatferium modpack switch
ferium profiles
should be an alias toferium profile list
(likewise forferium modpacks
too)ferium mods
should be an alias toferium list
ferium remove
should print the project id of the removed mods too