Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onDragStart onDragEnd gesture callbacks #1796

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arekkubaczkowski
Copy link

@arekkubaczkowski arekkubaczkowski commented Apr 10, 2024

Given the significant interest and numerous requests from the community for this feature, I'm excited to introduce it with this pull request.

resolves #998, #1147

@arekkubaczkowski
Copy link
Author

@gorhom I think it's also worth to add a callbacks that run on UI thread to react on the changes without unnecessary rerenders. However I need to think a bit about some intuitive API for that

@arekkubaczkowski
Copy link
Author

arekkubaczkowski commented Apr 11, 2024

Additionally I would also consider adding them to some hook so user can interact with it from any place.

@arekkubaczkowski
Copy link
Author

@gorhom I would be really grateful for review

@jakubdrozdek
Copy link

Awesome! Can't wait to see it merged. We've been patching this manually for quite some time. Would be nice to see it in the library.

@AndreiTimofte96
Copy link

Hi @arekkubaczkowski. Do you know when this awesome feature will be merged & released ?

@arekkubaczkowski
Copy link
Author

Hi @arekkubaczkowski. Do you know when this awesome feature will be merged & released ?

I have no idea, it seems like @gorhom is very busy.

@phillipkey
Copy link

@arekkubaczkowski - I am currently trying to tap into some functionality like this and I believe @gorhom's intent is to use gestureEventsHandlersHook to provide callbacks for handleOnStart, handleOnEnd, handleOnActive.

Am I missing the intent of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pan Gesture event
4 participants