Fix android issues with dynamic snap points and open keyboard + onAnimate values
#1163
Conversation
|
for any interested, here is a patch:
diff --git a/node_modules/@gorhom/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx b/node_modules/@gorhom/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
index b166440..ce74512 100644
--- a/node_modules/@gorhom/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
+++ b/node_modules/@gorhom/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
@@ -693,9 +693,9 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
/**
* store next position
*/
- animatedNextPosition.value = position;
+ animatedNextPosition.value = position + animatedKeyboardHeight.value;
animatedNextPositionIndex.value =
- animatedSnapPoints.value.indexOf(position);
+ animatedSnapPoints.value.indexOf(position + animatedKeyboardHeight.value); |
| const keyboardOffset = animatedKeyboardState.value == KEYBOARD_STATE.SHOWN ? animatedKeyboardHeight.value : 0; | ||
|
|
||
| animatedNextPosition.value = position + keyboardOffset; | ||
| animatedNextPositionIndex.value = position == 0 ? INITIAL_SNAP_POINT : animatedSnapPoints.value.indexOf(position + keyboardOffset); |
There was a problem hiding this comment.
When the position was 0 (from a fully extended sheet), the index was still specified as -1. But that had the implication that the sheet was closed/closing.
I thought to instead set it to INITIAL_SNAP_POINT (-999), as that conveys a better meaning, especially in the context of the onAnimate callback
paulrostorp
changed the title
onAnimate values
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
not stale cc @gorhom |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
not stale cc @gorhom |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
not stale cc @gorhom |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not stale |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Hi @paulrostorp, thanks for investigating and submitting this pr, could you please provide a reproducible sample code to test out the issue and validate the proposed solution ? thanks |
|
Probably it's related with this |
|
I think it may not be Android only as I'm having this on my app for both platform. It happened when the content size of the sheet changed. In my case, I have a helper text that changed its content depending on the input validation. I think what happened here is its trying to recalculate the sheet size since I've enabled dynamic sizing. The current workaround is to set a fixed height to the content. Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-17.at.22.05.13.mp4 |
Motivation
I was facing an issue on android when using dynamic snap points and the
adjustPansetting when content height changed while the keyboard was open. I think the following video best showcases the problem:Record_2022-10-31-12-56-43.mp4
as you can see, the height of the content changes when the validation text appears or disappears, thereby adding or removing about twenty pixels.
I've narrowed down the issue: because of the keyboard height, the appropriate
snapPointindex is not found and triggers the intermediary collapse of the sheet.I've tested this on android and ios:
I have not found this to cause any regressions, but there may be a better solution to this problem.
Edit:
Upon further investigation, I also found some issues with
onAnimatebeing provided with the wrong values (both ios and android), I've fixed that in 0c7e153, but I'm starting to think my fixes are not tackling the root issue, @gorhom please advise 🙂