Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cl: keep stmt comments #1870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cl: keep stmt comments #1870

wants to merge 1 commit into from

Conversation

CarlJi
Copy link
Member

@CarlJi CarlJi commented Apr 26, 2024

Refer #1864

This PR only fixes a portion of the scenarios, and there are still other TODO items that need to be handled, like:

  • go+ overload function comments
  • keep comments when no need add fileLine
  • do format for the generated code to adheres to the standard Go coding style

I will continue to follow up on these tasks in separate PRs.

@CarlJi CarlJi changed the title cl: keep stmt comments [WIP] cl: keep stmt comments Apr 26, 2024
@CarlJi CarlJi changed the title [WIP] cl: keep stmt comments cl: keep stmt comments Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.39%. Comparing base (5e44bc4) to head (40fd0c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   62.64%   63.39%   +0.75%     
==========================================
  Files         141      141              
  Lines       20584    20600      +16     
==========================================
+ Hits        12894    13060     +166     
+ Misses       7351     7203     -148     
+ Partials      339      337       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant