Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bit more time for comm dish detection for comms console #18873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlameArrow57
Copy link
Contributor

[GAME OBJECTS][QoL]

About the PR

Really minor, but for the communications console, the first time you login, run commaster, and then use the call command, it will give you an error message that the comms dish can't be connected, then a second after that comms were established. Typing call again, it will find it, and then ask you to enter your shuttle call reason

This just adds a bit more time so that you don't have to type call twice, just once, before entering the shuttle call reason

Why's this needed?

QoL

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024
@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play labels May 12, 2024
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make the comms dish detection faster?

@FlameArrow57
Copy link
Contributor Author

FlameArrow57 commented May 12, 2024

Why not make the comms dish detection faster?

Think the issue is with code below,
/obj/machinery/power/data_terminal/proc/post_signal(), which does a ~300 item loop as a part of this, including lag checks. Not specific to shuttle calling I think

image

Would require a lower level rework I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants