Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier ant prevention #18869

Merged
merged 6 commits into from
May 29, 2024
Merged

Easier ant prevention #18869

merged 6 commits into from
May 29, 2024
+8 −3

Conversation

nova2053
Copy link
Contributor

@nova2053 nova2053 commented May 12, 2024 •
edited

Labels

[CATERING] [QoL]

About the PR

Food items now have a one minute immunity to ants after having their loc changed.

Why's this needed?

It's annoying to open a crate or fridge full of food for just a couple seconds and have a whole bunch of ants spawn.

Changelog 

(u)nova2053
(+)Food items now have a one minute immunity to ants after being moved.

@nova2053
food items on the same tile as crates, closets,
a29074e 
and racks will no longer make ants
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024
ZeWaka
ZeWaka reviewed May 12, 2024
View reviewed changes
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit sus, I'd rather have some sort of delay before ants spawn when loc is changed

@nova2053
Copy link
Contributor Author

Seems a bit sus, I'd rather have some sort of delay before ants spawn when loc is changed

that could work, though i would still like to keep the functionality of racks preventing ants, because more food storage options are nice and it could be useful for stuff like walk-in freezers in the future

@ZeWaka
Copy link
Member

ZeWaka commented May 13, 2024

Seems a bit sus, I'd rather have some sort of delay before ants spawn when loc is changed

that could work, though i would still like to keep the functionality of racks preventing ants, because more food storage options are nice and it could be useful for stuff like walk-in freezers in the future

ants should just not spawn in cold temps

@nova2053
closets and crates are no longer immune to ants
411dba4 
food items now have a one minute immunity to
ants after being moved
racks still prevent ants
@nova2053 nova2053 changed the title food items on the same tile as crates, closets, Easier ant prevention May 13, 2024
@keywordlabeler keywordlabeler bot added A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff C-QoL A quality of life improvement that makes the game easier to play labels May 13, 2024
@nova2053
Copy link
Contributor Author

Seems a bit sus, I'd rather have some sort of delay before ants spawn when loc is changed

that could work, though i would still like to keep the functionality of racks preventing ants, because more food storage options are nice and it could be useful for stuff like walk-in freezers in the future

ants should just not spawn in cold temps

Makes sense, ill just remove the rack invulnerability to ants thing. also added the ant spawn delay like you recommended

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
ZeWaka
ZeWaka reviewed May 14, 2024
View reviewed changes
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TIME

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@nova2053
Copy link
Contributor Author

Use TIME

done, changed all instances of world.time in that code to TIME

ZeWaka
ZeWaka approved these changes May 29, 2024
View reviewed changes
code/modules/chemistry/tools/food_and_drink.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label May 29, 2024
@ZeWaka ZeWaka merged commit a7b789a into goonstation:master May 29, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@robuddybot
Changelog for #18869 [skip ci]
ea91157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azrun Azrun Azrun approved these changes

@ZeWaka ZeWaka ZeWaka approved these changes

Assignees
No one assigned
Labels
A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff C-QoL A quality of life improvement that makes the game easier to play S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nova2053 @ZeWaka @Azrun