Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Char liquefaction? #18866

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TobleroneSwordfish
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish commented May 12, 2024

[CHEMISTRY]

About the PR

Adds a rough approximation of coal liquefaction/hydrogenation: heating char in the presence of hydrogen will liquify it into oil with some welding fuel, carbon and kerosene mixed in as byproducts, and emitting some CO2 in the process.

Why's this needed?

Oil is a pain to make, more ways to make oil are cool, gives char more of a use. Someone said it in the discord and I thought it sounded cool.

Changelog

(u)LeahTheTech
(*)Added char liquefaction.
(+)write details here

@keywordlabeler keywordlabeler bot added the A-Chemistry Deals with the chemistry system in some way label May 12, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024
@MylieDaniels
Copy link
Contributor

MylieDaniels commented May 12, 2024

I worry that this could be very, very hard to prevent from just exploding. Producing multiple highly flammable chemicals in an open puddle in presence of open flame seems like a very... for lack of a better word, janky way to do this. In addition, neither oil nor kerosene are presently capable of becoming puddles, and allowing it but only in this specific case seems... odd?

@TDHooligan
Copy link
Contributor

this would be healthier, imo, to be considered 'hobo chem' and not as a legitimate chemistry method to be used in balance equations

buuuuut, we need more hobochem, so im incredibly down for this

@Tarmunora
Copy link
Member

Special effects on raw_material items themselves😔

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Chemistry Deals with the chemistry system in some way S-Stale An inactive PR that has had no updates in the past two weeks size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants