Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffs captain's office #18815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chatauscours
Copy link
Contributor

@Chatauscours Chatauscours commented May 8, 2024

[BALANCE]

About the PR

  • Reinforces captain's locker.
  • Makes captain's office access almost exclusive to the captain (and the spare). RP HoS no longer has access to cap's office. The Regional Director and NTSO units still have the access.
  • The standard ID console can no longer give out captain's office access.
  • Adds a new departamental ID console : Captain's. It requires captain's access to work on, and is the only ID console that can issue new IDs with captain's office access.
  • The new console has been placed in captain's offices on every in rotation map.

Why's this needed?

Makes captain a more serious role.

Changelog

(u)Chatauscours
(*) Captain's office access is now exclusive to the captain and CentCom employees.
(*) Captain's locker is now reinforced.

@keywordlabeler keywordlabeler bot added the C-Balance Balance changes, buffs and nerfs label May 8, 2024
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label May 8, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2024
@M-Earthfire
Copy link
Contributor

M-Earthfire commented May 8, 2024

I feel like "makes captain a more serious role" is quite insufficient for a reasoning for such a buff of a room. The "seriousness" of the role comes, well, from the roll itself, not the room they reside in.

Disregarding that, though, i feel like most of these changes makes sense. Except the captain's ID-computer. With the HOP taking on the acting captain role whenever the captain is dead/missing, i feel there is little to no reasoning why to deny them the ability to give themselves access to the captain's office, if needed.

Especially when the changes mean an inability to grant that access if the captain's ID/spare goes missing (which is the situation where the HOP most often becomes the acting captain).

@Chatauscours
Copy link
Contributor Author

Chatauscours commented May 8, 2024

Since with the current mechanics if the captain dies unclonably or cryoes, the slot opens up, I don't think the HoP needs captain's office access. Plus, they don't NEED the office access to be an acting captain.
What could of course be done is abandonning the new sign up system, for a system where an acting captain could retrieve the spare from a safe on the bridge or other secure location should the captain cryo/die.

@Sbmhawk
Copy link
Contributor

Sbmhawk commented May 8, 2024

I dont think having more stuff that the ID console cant do is a good idea, I dont see the need to disallow the HoP from acting as stand-in captain

The hos access already feels weird enough.

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label May 23, 2024
@Sord213 Sord213 removed their request for review May 23, 2024 17:48
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-Balance Balance changes, buffs and nerfs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants