Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndicate Factory - Planet Prefab #18801

Merged
merged 3 commits into from
May 28, 2024
Merged

Syndicate Factory - Planet Prefab #18801

merged 3 commits into from
May 28, 2024

Conversation

EEASAS
Copy link
Contributor

@EEASAS EEASAS commented May 7, 2024

[MAPPING]

About the PR

Adds a factory prefab, available on planets. It is taken by syndicates and barricaded.
The Danger: 4 melee syndicates, 1 rifle syndicate
The Loot: 1 Makarov, 2 Makarov magazines, 2 patch boxes, one is for brute, and other is for burns. 2 drug crate spawners, 4 10% chance loot spawns
The Defense: Barricades surrounded by barbed wire. Building is made out of reinforced walls with concrete floors
68747470733a2f2f616666656374656461726330372e626c6f622e636f72652e77696e646f77732e6e65742f6d6462322f696d616765732f3235323034373438332f32343638393534363934352f612f6173736574735f6d6170735f707265666162735f706c616e6574
(outdated image, check mapdiff2 in checks tab)

Why's this needed?

More artemis ruins are good, i think

No changelog because yes

@keywordlabeler keywordlabeler bot added the A-Mapping A mapping change label May 7, 2024
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 7, 2024
@EEASAS EEASAS closed this May 7, 2024
@EEASAS
Copy link
Contributor Author

EEASAS commented May 7, 2024

nevermind

@EEASAS EEASAS reopened this May 7, 2024
@Azrun Azrun changed the title New prefab for planets Syndicate Factory - Planet Prefab May 10, 2024
@Azrun Azrun self-requested a review May 10, 2024 18:48
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label May 25, 2024
Copy link
Contributor

@Azrun Azrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, these should probably be tagged in a manner such that it is easy to individually select the theming of a planet or terrainify. That way the presence of syndicate prefabs makes more contextual sense instead of being randomly dropped in.

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label May 27, 2024
@Azrun Azrun merged commit 316bb84 into goonstation:master May 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants