Removes Max Trait Limit #18797
Merged
Removes Max Trait Limit #18797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frawhst
added
C-Balance
github-actions
bot
added
the
size/XS
goonstation-issuebot
added
the
S-Testmerged
This was referenced May 7, 2024
|
previously: ghost examining someone with a lot of traits is... yeah. possibly make traits not occupy a line each? fixed in recent pr |
This was referenced May 7, 2024
Closed
This was referenced May 21, 2024
Closed
Open
mordent-goonstation
requested review from
mordent-goonstation,
ZeWaka and
Tarmunora
as code owners
boring-cyborg
bot
added
the
A-UI
|
!merge_upstream |
This was referenced May 23, 2024
goonstation-issuebot
removed
the
S-Testmerged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Sets the max number of selectable traits to
INFINITYThis might need a quick revert if it leads to extremely broken bullshit. There's too many traits to reasonably test all the combinations of, so I'm just letting this one fly.
Why's this needed?
Might be fun. Points should already be a limiter on traits, don't need a maximum number as well.
Changelog