Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearranges some rooms on Mushroom #18793

Closed
wants to merge 45 commits into from

Conversation

cheekybrdy
Copy link
Contributor

@cheekybrdy cheekybrdy commented May 6, 2024

About the PR

5/6 Departments are in the south of Mushroom, this PR moves mechlab as a high traffic area back to its home department to generate more traffic in the north, then moves emergency storage A which was where mechlab was to ranch, which has been moved to a new area in what is currently space west of botany. Warehouse has had a small cleanup and a public refinery added. The area where mechlab was is now a stock exchange with a market stall to make the most out of the high traffic of the south. The random room behind mechlab has been made to a supply closet for janitors as while them having to go all the way to the top of the map to resupply can generate traffic in the northern hallways it was in a very anti-qol way. Also adds 2 escape pods at escape and one in maint near brig, as the map previously had no escape pods.

Why's this needed?

Gives Mushroom's northern hallways some more visited areas which are returned to in order to pull traffic from the cluttered south.

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label May 6, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 6, 2024
Copy link
Contributor

@Sord213 Sord213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan in general. Don't like gluing the ranch to the exterior of botany, don't like the random third market stall/stock market, and just moving the emergency storage on top of the warehouse feels weird. "Here's the big storage room on top of the big storage room"

@cheekybrdy
Copy link
Contributor Author

Done some adjustments for the concern areas of the PR, removed the ranch area and instead put Emergency Storage A where the stock exchange was, moved Ranch to crew quarters and vice versa for where ranch initially was

@cheekybrdy cheekybrdy requested a review from Sord213 May 10, 2024 23:43
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label May 15, 2024
@cheekybrdy
Copy link
Contributor Author

!merge_upstream

Copy link
Contributor

@cheekybrdy
Copy link
Contributor Author

Closing due to me being incompetent at conflict fixes, will reopen the revised version post feedback

@cheekybrdy cheekybrdy closed this May 20, 2024
@cheekybrdy cheekybrdy deleted the mechlab-move-mushroom branch May 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants