Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Unconcious People to Hear Speech #18697

Closed
wants to merge 3 commits into from

Conversation

frawhst
Copy link
Member

@frawhst frawhst commented May 1, 2024

[FEEDBACK] [PLAYER ACTIONS] [EXPERIMENTAL] [QoL]

About the PR

Does that thing. Lets unconcious people hear chat, see radio chat, and see maptext. May have some minor discrepancies (haven't tested with intercom maptext), because speech code sux.

Why's this needed?

Currently being put under for surgery, in a sleeper, getting knocked out by chemicals or N2O, etc etc etc all suck to experience because you're vastly removed from the round during them, and can't keep track of what's going on at all. This lessens that somewhat.

Notably this gives a bit more power to people who are being knocked out and kidnapped or whatever, but that's such a low percent of all cases of being knocked out that, imo, this is by far a net good.

This is a very simple implementation, I'd be happy to introduce more intricacies to it if people would like.

(u)aloe
(*)Unconscious people can now hear speech normally.

@keywordlabeler keywordlabeler bot added A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. C-QoL A quality of life improvement that makes the game easier to play E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels May 1, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

Created discussion thread: https://forum.ss13.co/showthread.php?tid=22575

@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label May 1, 2024
@frawhst
Copy link
Member Author

frawhst commented May 1, 2024

It's been suggested to muffle the heard speech somewhat and only let unconscious people hear bits and pieces of what's being said (as in, "i am going to throw this guy into space" might become "... going to th ... this guy ... space" or similar").

will take a crack at implementing that sometime soon.

@DecidedlyUnethical
Copy link
Contributor

DecidedlyUnethical commented May 2, 2024

Really don't like this; you're unconscious, you shouldn't be hearing dip. Already we have people jumping out of the cloner after dying, and immediately screaming on the radio "JOHN STAFFMAN KILLED ME IN XYZ, HE'S A TRAITOR!" resulting in said traitor getting witchhunted no matter HOW well they built up and escalated a murder.

You can't trust people not to meta with this.

Also, people can full hear the radio while they're in cryo (not ghost cryo), not sure if that's an oversight or intended.
(Edit: Formatting, sentence structure)

@PastaSpaghett
Copy link

Might help to make it so people in a grab are fully deafened while unconscious.

@goonstation-issuebot goonstation-issuebot removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label May 5, 2024
@Kyle2143
Copy link
Contributor

It's been suggested to muffle the heard speech somewhat and only let unconscious people hear bits and pieces of what's being said (as in, "i am going to throw this guy into space" might become "... going to th ... this guy ... space" or similar").

This is a much better way. Also I'd say it shouldn't tell you the name of who says what. Just that "a muffled voice says "blah...blah blah...bla".

@frawhst
Copy link
Member Author

frawhst commented May 29, 2024

Going to be away for a bit so closing till then!

@frawhst frawhst closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. C-QoL A quality of life improvement that makes the game easier to play E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants