Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deluxe Agent Card - HoP traitor item #18693

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JORJ949
Copy link
Contributor

@JORJ949 JORJ949 commented May 1, 2024

About the PR

Adds the "deluxe agent card", a reusable version of the agent card allowing for on the run identity crafting for 3 tc

Why's this needed?

HoP only has the AI law traitor items and thats kinda boring

Changelog

(u)JORJ949
(*)The Head of Personnel can now buy a reusable "Deluxe" agent card. Also available to spy thieves and nuclear operatives.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2024
@JORJ949 JORJ949 added C-Feature A new feature or enhancements to existing features A-Game-Objects The point of this PR is to deal with a specific game object labels May 1, 2024
@TDHooligan
Copy link
Contributor

might be too crazy? just swapping your ID freely, constantly, without being near an ID computer. could make it way too easy to entirely fuck up any and all comms with just a voice changer.

@JORJ949
Copy link
Contributor Author

JORJ949 commented May 1, 2024

might be too crazy? just swapping your ID freely, constantly, without being near an ID computer. could make it way too easy to entirely fuck up any and all comms with just a voice changer.

You'd also need to carry extra radios but good point, you do need to spend like 5-10s entering all the new details though. This can already technically be done by a HoP, just fill a box with spare (non-agent) IDs with names and you have a fairly similar thing though I have never seen this done and IMO wouldnt be a huge issue as if you come across a communication issue you can swap to PDA messenger, which you cant change on the fly and would need to carry extra PDAs with you

@JORJ949 JORJ949 added the E-Add-To-Wiki A PR that will require changes to the wiki label May 1, 2024
@M-Earthfire
Copy link
Contributor

might be too crazy? just swapping your ID freely, constantly, without being near an ID computer. could make it way too easy to entirely fuck up any and all comms with just a voice changer.

On other code bases, the agent card has the ability to change itself multiple times and it works without that many problems. So i personaly think it would be fine.

But i also think it does not need to be a HOP-exclusive item. This could fit pretty snuggly in the general traitor list, especially with a whopping 3TC cost.

By the way, i would certainly add the TC-cost if the item in the PR's description.

@JORJ949
Copy link
Contributor Author

JORJ949 commented May 3, 2024

might be too crazy? just swapping your ID freely, constantly, without being near an ID computer. could make it way too easy to entirely fuck up any and all comms with just a voice changer.

If this does become an issue it would be a fairly simple change to just add a limit on how many uses it has

@JORJ949
Copy link
Contributor Author

JORJ949 commented May 12, 2024

But i also think it does not need to be a HOP-exclusive item. This could fit pretty snuggly in the general traitor list, especially with a whopping 3TC cost.

This was made because HoP had no real exclusive items other than AI stuff which isn't great and also while it could possibly fit in the main traitor menu I wouldnt want to see it used too much because of the potential it has that TD pointed out.

Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label May 27, 2024
@JORJ949
Copy link
Contributor Author

JORJ949 commented May 27, 2024

:/

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label May 29, 2024
@FronkyGeniuZ
Copy link

Woah cool idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features E-Add-To-Wiki A PR that will require changes to the wiki size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants