Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused Accesses from IDs #18684

Closed
wants to merge 2 commits into from
Closed

Remove Unused Accesses from IDs #18684

wants to merge 2 commits into from

Conversation

JORJ949
Copy link
Contributor

@JORJ949 JORJ949 commented Apr 30, 2024 •
edited

About the PR

Removes the old armory access from the ID cards that still had it (AA, HoS, HoP) and changes an object I believe to be unused to instead just use security access.
Also removes access_mail from IDs

Anything "unused" but that had a mapping helper or was in ID computer wasnt touched

Why's this needed?

CE RCD can use any access in "get_all_accesses" and it probably shouldn't be able to make unused accesses. Specifically ones that can't be given out by the ID computer and are only available to a few roundstart roles.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 30, 2024
@JORJ949 JORJ949 changed the title Remove "access_armory" from IDs Remove Unused Accesses from IDs Apr 30, 2024
@JORJ949 JORJ949 added C-Code-Quality Cleans up code, refactors things to be more readable or intuitive A-Game-Objects The point of this PR is to deal with a specific game object labels Apr 30, 2024
ZeWaka
ZeWaka requested changes May 6, 2024
View reviewed changes
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not remove them entirely so they don't accidentally get used

@JORJ949
Copy link
Contributor Author

JORJ949 commented May 12, 2024

why not remove them entirely so they don't accidentally get used

For a couple reasons:
-This was meant to be a quick fix for the RCD showing "Armory" as an access and confusing new players that it isnt armory
-Some places use the actual value of the access so just shifting all accesses below them up one would probably break a lot of stuff
-Just leaving blank spots in the list would feel wrong and may break some stuff
-I'd rather see them repurposed than just removed.

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label May 20, 2024
@JORJ949
Copy link
Contributor Author

JORJ949 commented May 20, 2024

Closing because there are much better solutions to this.

@JORJ949 JORJ949 closed this May 20, 2024
@JORJ949 JORJ949 deleted the remove-access_armory-from-IDs branch May 27, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeWaka ZeWaka ZeWaka requested changes

Assignees
No one assigned
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Code-Quality Cleans up code, refactors things to be more readable or intuitive S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JORJ949 @ZeWaka