Unify TEG valve names #18603
Unify TEG valve names #18603
Conversation
github-actions
bot
added
the
size/L
keywordlabeler
bot
added
A-Station-Systems
maps/atlas.dmm
Outdated
| @@ -15289,7 +15289,7 @@ | |||
| "aYV" = ( | |||
| /obj/machinery/atmospherics/binary/valve{ | |||
| dir = 4; | |||
| name = "hot loop purge valve" | |||
| name = "hot loop pressure release valve" | |||
There was a problem hiding this comment.
I think purge valve is a better name because it's more obvious that this is the "dump all of your gas into space" valve, also it's what most people call it currently.
| @@ -57703,6 +57714,13 @@ | |||
| }, | |||
| /turf/simulated/floor/blue, | |||
| /area/station/science/lab) | |||
| "eNY" = ( | |||
| /obj/machinery/atmospherics/binary/valve{ | |||
| desc = "hot radiator outlet valve"; | |||
There was a problem hiding this comment.
| desc = "hot radiator outlet valve"; |
| @@ -163,7 +163,7 @@ | |||
| }, | |||
| /obj/machinery/atmospherics/binary/valve{ | |||
| dir = 4; | |||
| name = "cold loop auxillary west" | |||
| name = "cold loop auxillary" | |||
There was a problem hiding this comment.
Should end in "valve"
| @@ -186,7 +186,7 @@ | |||
| "iO" = ( | |||
| /obj/machinery/atmospherics/binary/valve{ | |||
| dir = 4; | |||
| name = "hot loop auxillary west" | |||
| name = "hot loop auxillary" | |||
| /obj/cable{ | ||
| icon_state = "1-2" | ||
| }, | ||
| /obj/machinery/atmospherics/binary/valve{ | ||
| desc = "cold reserve tank valve"; |
There was a problem hiding this comment.
| desc = "cold reserve tank valve"; |
| /obj/cable{ | ||
| icon_state = "1-2" | ||
| }, | ||
| /obj/machinery/atmospherics/binary/valve{ | ||
| desc = "hot radiator outlet valve"; |
There was a problem hiding this comment.
| desc = "hot radiator outlet valve"; |
| @@ -31308,7 +31308,10 @@ | |||
| name = "News Office Bathroom" | |||
| }) | |||
| "dcI" = ( | |||
| /obj/machinery/atmospherics/binary/valve, | |||
| /obj/machinery/atmospherics/binary/valve{ | |||
| desc = "hot radiator inlet valve"; | |||
There was a problem hiding this comment.
| desc = "hot radiator inlet valve"; |
| @@ -68297,6 +68316,13 @@ | |||
| }, | |||
| /turf/simulated/floor/caution/south, | |||
| /area/station/engine/hotloop) | |||
| "pSs" = ( | |||
| /obj/machinery/atmospherics/binary/valve{ | |||
| desc = "hot radiator inlet valve"; | |||
There was a problem hiding this comment.
| desc = "hot radiator inlet valve"; |
|
incorporated the feedback, what do you mean with the removal of the radiator valves btw? Cause I think it's nice to have as well to mark their in and outputs more clearly |
|
Oh, no it's just that you've varedited their descriptions as well as their names |
github-actions
bot
added
the
S-Merge-Conflict
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
[STATION SYSTEMS] [QoL]
About the PR
Changes names for manual valves in the engine rooms of kondaru, cog1, cog2, and atlas to be the same across all of them and label what the valves actually do (e.g. inlet and outlet valves named explicitly).
Why's this needed?
Accessibility through having valves describe what they are for allowing new players to learn how to set up an engine and have said skill be more easily transferable to other TEG layouts.
Changelog