Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(places): correct typo in places detail fields #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

il-santo
Copy link

Currently there is a typo in googlemaps/places.py that prevents the retrieval ot the address components array.

This commit fixes the above mentioned typo.

@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@il-santo
Copy link
Author

CLA should pass. Why is it not doing it?

@LLyaudet
Copy link

LLyaudet commented Jan 4, 2024

Hello :),
It seems you have trouble to sign the CLA.
I don't see anything else that should prevent merging this PR.
I will upvote on the issue.
I also checked the documentation : https://developers.google.com/maps/documentation/places/web-service/reference/rest/v1/places?hl=en
It seems many other fields should be corrected :
adr_address corresponds to nothing apparently.
Best regards,
Laurent Lyaudet

@il-santo il-santo closed this Jan 4, 2024
@il-santo il-santo reopened this Jan 4, 2024
@il-santo
Copy link
Author

il-santo commented Jan 4, 2024

Hello :), It seems you have trouble to sign the CLA. I don't see anything else that should prevent merging this PR.

It simply doesn't work.

I signed the CLA several times, and it seems ok, but if I follow the procedure to rescan the PR as a first time contributor I get a 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants