Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy integration #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

uriyyo
Copy link

@uriyyo uriyyo commented Mar 21, 2023

Add mypy integration.

Drop python 3.5 and 3.6 versions cause they reach EOL.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #444

@uriyyo uriyyo requested a review from a team as a code owner March 21, 2023 11:16
@uriyyo uriyyo requested a review from willum070 March 21, 2023 11:16
@google-cla
Copy link

google-cla bot commented Mar 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@msdrigg
Copy link

msdrigg commented Nov 15, 2023

I'd like to see this as well

@stianjensen
Copy link

This would be great! Not sure if the library has any active maintainers anymore, though 😕

@AAraKKe
Copy link

AAraKKe commented Apr 2, 2024

Is this going to be merged or planed? It seems it has been over a year since there has been any update on the library. It has become almost standard to do type check and using this library means a bunch of type ignroes need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for mypy and typing
5 participants