refactor: replace most GoogleMap() rememberUpdatedState() usages with single State object and encapsulate subcomposition functionality #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… single State object and encapsulate subcomposition functionality Fixes googlemaps#492
|
@wangela can I get a review & merge for this PR, please? It is functionally equivalent to current code, but improves code organization/clarity and offers minor performance improvements due to fewer slots used and less work performed on Compose parameter equality testing. This being a refactor I'd like to avoid recurring merge conflicts by merging it soon. Thanks. |
|
Bump |
|
Hi @bubenheimer , thanks for the contribution. This looks good, gets the codebase a bit closer to the API design guidelines and improves overall the health of the repository. |
kikoso
approved these changes
Apr 18, 2024
kikoso
changed the title
philip-segerfast
added a commit
to philip-segerfast/android-maps-compose
that referenced
this pull request
May 9, 2024
…operty from MapApplier [see desc.] - Wrap MapUpdater parameters inside a MapUpdaterState data class - Remove MapClickListeners property from MapApplier - Pass MapClickListeners directly to MapClickListenerUpdater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492