New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove maps v3beta #1117
base: main
Are you sure you want to change the base?
Remove maps v3beta #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pull request!
- All the files under /src/gms/java/com/example/mapdemo and /src/gms/res should be moved to /src/main, not deleted.
- Recommend leaving ApiDemos/java/gradle/wrapper/gradle-wrapper.properties unchanged as Gradle dependencies should be updated in a separate PR to keep the scope of this PR tidy.
- Since new commits have been merged since this PR, please sync your fork and resolve any merge conflicts
@@ -1,5 +1,6 @@ | |||
.gradle | |||
/local.properties | |||
/local.defaults.properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be gitignored
// V3 | ||
v3Implementation 'com.google.android.libraries.maps:maps:3.1.0-beta' | ||
|
||
// Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the tests lines
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃