Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maps v3beta #1117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

regeter
Copy link

@regeter regeter commented Dec 2, 2022

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@snippet-bot
Copy link

snippet-bot bot commented Dec 2, 2022

Here is the summary of changes.

You are about to delete 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@regeter regeter closed this Dec 2, 2022
@regeter regeter reopened this Dec 6, 2022
@amuramoto amuramoto assigned wangela and unassigned amuramoto Dec 6, 2022
@wangela wangela self-requested a review December 6, 2022 20:14
Copy link
Contributor

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request!

  1. All the files under /src/gms/java/com/example/mapdemo and /src/gms/res should be moved to /src/main, not deleted.
  2. Recommend leaving ApiDemos/java/gradle/wrapper/gradle-wrapper.properties unchanged as Gradle dependencies should be updated in a separate PR to keep the scope of this PR tidy.
  3. Since new commits have been merged since this PR, please sync your fork and resolve any merge conflicts

@@ -1,5 +1,6 @@
.gradle
/local.properties
/local.defaults.properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be gitignored

// V3
v3Implementation 'com.google.android.libraries.maps:maps:3.1.0-beta'

// Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the tests lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants