Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps to Promote SDK Features from Alpha to Beta #3814

Merged
merged 12 commits into from May 15, 2024

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

pkg/util/runtime/features.go Outdated Show resolved Hide resolved
pkg/util/runtime/features.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c8118487-0a58-4293-a034-37ded6501cd8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3814/head:pr_3814 && git checkout pr_3814
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-b81eb78-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c7aae1e4-71f1-456d-860f-897fc42101a9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/util/runtime/features.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6e3bbc4-2045-4171-8d80-89ddc20f6da1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3814/head:pr_3814 && git checkout pr_3814
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-da3d117-amd64

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these suggestions closer to the intent?

pkg/util/runtime/features.go Outdated Show resolved Hide resolved
pkg/util/runtime/features.go Outdated Show resolved Hide resolved
pkg/util/runtime/features.go Outdated Show resolved Hide resolved
pkg/util/runtime/features.go Outdated Show resolved Hide resolved
pkg/util/runtime/features.go Outdated Show resolved Hide resolved
@Kalaiselvi84
Copy link
Contributor Author

@igooch, I have updated the steps as per your suggestion.

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion, then LGTM.

pkg/util/runtime/features.go Outdated Show resolved Hide resolved
@igooch igooch enabled auto-merge (squash) May 13, 2024 20:57
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: cade7a49-b111-45e4-a26a-590ed095e69a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f1bdec1a-9de7-4b9a-b432-d1d41937efa1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: db5e1629-8992-48f5-a376-ba789ad24e42

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Any extra thoughts @igooch ?

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Already approved! In which case, double approved!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c5a97503-cabe-4cae-bcf7-f96e32cefa33

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 59bf6033-1f95-4f04-8ce3-023852f76de5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5795610c-81c9-4bba-b572-640a1d7e047a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8cababde-2c13-4ccd-8c64-80717283e48e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 22b83230-f06c-49eb-ace6-8a2f45d5b756

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1833a6dc-d22c-4e74-bd8d-c9b37b35a3e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3814/head:pr_3814 && git checkout pr_3814
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-06f7312-amd64

@igooch igooch merged commit 7d168a4 into googleforgames:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants