This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Migrating to Typescript #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cgilson
commented
Apr 21, 2016
cgilson
commented
- Modified project structure to more closely match other TS projects
- Removed dead code (case-map)
- Typescript!
| @@ -141,7 +143,7 @@ function runWithOptions(options) { | |||
| if (options['config-file'] && options['config-field']) { | |||
| var field = options['config-field']; | |||
| try { | |||
| var contents = fs.readFileSync(options['config-file']); | |||
| var contents:any = fs.readFileSync(options['config-file']); | |||
There was a problem hiding this comment.
Favor let over var wherever possible.
Create a new variable name instead of avoiding type checks for contents.
Move argument definitions to their own library
Add logging libraries and basic debug logging
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.