This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 210
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #167 from firebase/moe_writing_branch_from_d8ce59d…
…f571cf56fc0947e1bbc6f345b42a92090 Fixes GooglePlayReceiver synchronization and leaking connections
- Loading branch information
Showing
18 changed files
with
552 additions
and
144 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
212 changes: 212 additions & 0 deletions
212
...atcher/src/androidTest/java/com/firebase/jobdispatcher/ExecutionDelegatorAndroidTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,212 @@ | ||
| // Copyright 2016 Google, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| package com.firebase.jobdispatcher; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| import android.content.Context; | ||
| import android.support.test.InstrumentationRegistry; | ||
| import android.support.test.runner.AndroidJUnit4; | ||
| import java.util.HashSet; | ||
| import java.util.Set; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.TimeUnit; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| /** Android test for {@link ExecutionDelegator}. */ | ||
| @RunWith(AndroidJUnit4.class) | ||
| public class ExecutionDelegatorAndroidTest { | ||
|
|
||
| private static final int TIMEOUT_SECONDS = 10; | ||
|
|
||
| private Context appContext; | ||
| private JobInvocation finishedJobInvocation; | ||
| private int jobResult; | ||
| private ExecutionDelegator executionDelegator; | ||
| private final JobInvocation jobInvocation = | ||
| new JobInvocation.Builder() | ||
| .setTag("tag") | ||
| .setService(TestJobService.class.getName()) | ||
| .setTrigger(Trigger.NOW) | ||
| .build(); | ||
| private volatile CountDownLatch startLatch; | ||
| private volatile CountDownLatch stopLatch; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| appContext = InstrumentationRegistry.getTargetContext(); | ||
| TestJobService.reset(); | ||
| finishedJobInvocation = null; | ||
| jobResult = -1; | ||
| executionDelegator = | ||
| new ExecutionDelegator( | ||
| appContext, | ||
| /* jobFinishedCallback= */ (jobInvocation, result) -> { | ||
| finishedJobInvocation = jobInvocation; | ||
| jobResult = result; | ||
| }); | ||
| startLatch = new CountDownLatch(1); | ||
| stopLatch = new CountDownLatch(1); | ||
|
|
||
| ExecutionDelegator.cleanServiceConnections(); | ||
|
|
||
| TestJobService.setProxy( | ||
| new TestJobService.JobServiceProxy() { | ||
| Set<String> runningJobs = new HashSet<>(); | ||
|
|
||
| @Override | ||
| public boolean onStartJob(JobParameters params) { | ||
| if (runningJobs.add(params.getTag())) { | ||
| startLatch.countDown(); | ||
| } else { | ||
| fail("Job was already started."); | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean onStopJob(JobParameters params) { | ||
| if (runningJobs.remove(params.getTag())) { | ||
| stopLatch.countDown(); | ||
| } else { | ||
| fail("Job was not running."); | ||
| } | ||
| return false; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void execute() throws InterruptedException { | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue( | ||
| "Latch wasn't counted down as expected", | ||
| startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| @Test | ||
| public void executeAndStopWithResult() throws InterruptedException { | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("Job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| verifyStopRequestWasProcessed(true); | ||
| } | ||
|
|
||
| @Test | ||
| public void executeAndStopWithoutResult() throws InterruptedException { | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("Job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| verifyStopRequestWasProcessed(false); | ||
| } | ||
|
|
||
| @Test | ||
| public void execute_unbind_jobStopped() throws InterruptedException { | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("Job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| synchronized (ExecutionDelegator.serviceConnections) { | ||
| ExecutionDelegator.serviceConnections.get(jobInvocation).unbind(); | ||
| } | ||
|
|
||
| assertTrue("Job should be stopped.", stopLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| @Test | ||
| public void execute_twice_stopAndRestart() throws InterruptedException { | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("Job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| startLatch = new CountDownLatch(1); | ||
|
|
||
| executionDelegator.executeJob(jobInvocation); | ||
|
|
||
| assertTrue("First job should be stopped.", stopLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
| assertTrue("Job should be started again.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| @Test | ||
| public void execute_afterStopWithResult_jobServiceStartedAgain() throws InterruptedException { | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("Job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| verifyStopRequestWasProcessed(true); | ||
|
|
||
| ExecutionDelegator.stopJob(jobInvocation, true); | ||
| ExecutionDelegator.stopJob(jobInvocation, true); // should not throw when called again | ||
|
|
||
| startLatch = new CountDownLatch(1); | ||
|
|
||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("Job should be started again.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| @Test | ||
| public void executeTwoJobs_stopFirst_secondStays() throws InterruptedException { | ||
| JobInvocation secondJobInvocation = | ||
| new JobInvocation.Builder() | ||
| .setTag("secondJob") | ||
| .setService(TestJobService.class.getName()) | ||
| .setTrigger(Trigger.NOW) | ||
| .build(); | ||
|
|
||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue("First job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| startLatch = new CountDownLatch(1); | ||
| executionDelegator.executeJob(secondJobInvocation); | ||
| assertTrue( | ||
| "Second job should be started.", startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| ExecutionDelegator.stopJob(jobInvocation, false); | ||
|
|
||
| assertTrue("First job should be stopped.", stopLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| synchronized (ExecutionDelegator.serviceConnections) { | ||
| assertFalse(ExecutionDelegator.serviceConnections.get(secondJobInvocation).wasUnbound()); | ||
| } | ||
|
|
||
| startLatch = new CountDownLatch(1); | ||
| executionDelegator.executeJob(jobInvocation); | ||
| assertTrue( | ||
| "First job should be started again because it was stopped.", | ||
| startLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
| } | ||
|
|
||
| private void verifyStopRequestWasProcessed(boolean withResult) throws InterruptedException { | ||
| ExecutionDelegator.stopJob(jobInvocation, withResult); | ||
|
|
||
| CountDownLatch latch = new CountDownLatch(1); | ||
| executionDelegator.responseHandler.post(() -> latch.countDown()); | ||
| assertTrue( | ||
| "All messages need to be processed.", latch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS)); | ||
|
|
||
| if (withResult) { | ||
| assertEquals(jobInvocation, finishedJobInvocation); | ||
| assertEquals(JobService.RESULT_SUCCESS, jobResult); | ||
| } else { | ||
| assertNull(finishedJobInvocation); | ||
| assertEquals(-1, jobResult); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.