Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python-library): add missing changes #710

Merged
merged 1 commit into from Jul 31, 2020
Merged

fix(python-library): add missing changes #710

merged 1 commit into from Jul 31, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 31, 2020

Somehow some changes are missing from the template.

@tmatsuo tmatsuo requested a review from busunkim96 July 31, 2020 01:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@tmatsuo tmatsuo merged commit 39b527a into googleapis:master Jul 31, 2020
@tmatsuo tmatsuo deleted the fix-python-docs-job branch July 31, 2020 01:26
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 31, 2020

@busunkim96 FYI, I run synthtool manually with texttospeech and got the expected result:
googleapis/python-texttospeech#73

The docs job failed, but it failed for different reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@bcoe bcoe Awaiting requested review from bcoe

@chingor13 chingor13 Awaiting requested review from chingor13

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmatsuo @busunkim96